-
Notifications
You must be signed in to change notification settings - Fork 156
Add kibana.alert.original_data_stream
to the list of alert schema fields
#3011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kibana.alert.original_data_stream
to the list of alert schema fields
#3011
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@florent-leborgne thanks for this! A few comments:
|
| [`dns.*`](ecs://reference/ecs-dns.md) | ECS `dns.*` fields copied from the source document, if present, for custom query and indicator match rules. | | ||
| [`error.*`](ecs://reference/ecs-error.md) | ECS `error.*` fields copied from the source document, if present, for custom query and indicator match rules. | | ||
| [`event.*`](ecs://reference/ecs-event.md) | ECS `event.*` fields copied from the source document, if present, for custom query and indicator match rules.<br>**Note:** categorization fields above (`event.kind`, `event.category`, `event.type`, `event.outcome`) are listed separately above. | | ||
| [`event.*`](ecs://reference/ecs-event.md) | ECS `event.*` fields copied from the source document, if present, for custom query and indicator match rules.<br>**Note:** categorization fields (`event.kind`, `event.category`, `event.type`, `event.outcome`) are listed separately. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to the feedback but the double "above" sounded off.
@rylnd Thanks for your comments! Let me know if this now looks closer to what you expected :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
@rylnd @yctercero let me know if I got this right or suggest anything you'd like to see. The original issue mentions that
kibana.alert.original_event.*
behaves similarly but it's not described much in the docs from what I could find, so we may also clarify things for that one if you feel it's needed.Once we're good with the content here, I'll create the corresponding PR for 8.19, as docs for this version are still in asciidoc in their previous location.
Closes: #2673