-
Notifications
You must be signed in to change notification settings - Fork 156
Clarify ECE - document host maintenance with podman #3066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this section. provided some small pieces of feedback (mostly formatting)
:::{note} | ||
This section only applies to Podman. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be correct that the docker steps are only for docker installations?
suggest that the title makes tihs clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be correct that the docker steps are only for docker installations?
yep. If making that sort of note under podman, might it make sense to do the same under docker?
What if the page is also reorganized in this fashion to group by method/intent?
- By disabling the container services (nondestructive):
- For Docker-based installations: Disabling the Docker service
- For Podman-based installations: Disabling the Podman-related services
- By deleting the host (destructive)
- By shutting down the host (less destructive)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ I like this nesting idea 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea! I updated - 56dde2d
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
tweaked the structure to make it nested and fixed the numbering
Thank you Shaina and Roberto! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really great. a couple last little style things and then good to go from my pov
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pfcoperez @matt-elastic can one of you please kindly review this to prevent future SDH tickets? Thanks Shaina and Roberto for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you! |
Description
https://github.com/elastic/docs-content-internal/issues/347
Preview - Before PR merge
deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
Preview - After PR merge
https://www.elastic.co/docs/deploy-manage/maintenance/ece/perform-ece-hosts-maintenance