-
Notifications
You must be signed in to change notification settings - Fork 156
remove duplicate content for certain SQL sections under Explore and Analyze #3117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate content for certain SQL sections under Explore and Analyze #3117
Conversation
…s under Explore analyze > SQL
…QL-doc-pages' into remove-and-redirect-duplicated-SQL-doc-pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved.
A suggestion/question: I've recently removed duplicated pages that existed in both the Deploy and manage and Reference sections in favour of the latter. I then added a crosslink to the toc in the Deploy and manage section because it made a lot of sense for the page to be listed in the toc. (It now redirects to the correct, deduplicated page in the Reference section.)
Not sure if this would apply to your use-case, but thought I'd mention it anyway.
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
I see! But I think, as per the requirement listed in the issue, this content should only sit in the Reference docs. Good to clear with @florent-leborgne though. Thanks @yetanothertw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ketkee-aryamane!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (noted a couple of missing spaces) 🥳
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Linked to #2563
This PR removes the following under Explore and Analyze -> SQL and creates redirects to the corresponding reference content. Also updates all referred links to these files with the reference content links.