Skip to content

Conversation

florent-leborgne
Copy link
Contributor

@florent-leborgne florent-leborgne commented Sep 24, 2025

Reviewers, this PR:

  • replaces the existing markers with what seems to be the most appropriate equivalent applies_to
  • removes a couple of markers that didn't feel appropriate or felt too granular

Please check that the changes for the areas you own are correct, or suggest edits where appropriate.
Note: some of those look really old, they may not be necessary anymore. If you know about it, suggest to remove the applies_to.

Tip:
image

Part of: #2951

@florent-leborgne florent-leborgne requested review from a team as code owners September 24, 2025 09:45
Copy link

github-actions bot commented Sep 24, 2025

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most of these are out of date. I left comments for the ones in my areas.

…s.md

Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of my "owned" files were alerts and reporting, which I skipped.

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
: Default catalog (cluster) for queries. If unspecified, the queries execute on the data in the local cluster only.

[preview] See [{{ccs}}](../../../solutions/search/cross-cluster-search.md).
See [{{ccs}}](../../../solutions/search/cross-cluster-search.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if want to maintain this preview marker here but it's clearly marked in the linked file

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛵

@florent-leborgne florent-leborgne enabled auto-merge (squash) September 26, 2025 08:01
@florent-leborgne florent-leborgne merged commit 41a65a4 into elastic:main Sep 26, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants