Skip to content

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Oct 1, 2025

This PR adds the new appearance settings for the metric chart.

Closes #3088
Relates to elastic/kibana#229815 and elastic/kibana#233992

@alaudazzi alaudazzi self-assigned this Oct 1, 2025
@alaudazzi alaudazzi requested review from a team as code owners October 1, 2025 08:30
@alaudazzi alaudazzi added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 1, 2025
Copy link

github-actions bot commented Oct 1, 2025

🔍 Preview links for changed docs

@alaudazzi
Copy link
Contributor Author

@mariairiartef
Do you think we should be more explicit about the fact that the Secondary metric alignment and the icon position are enabled only when a secondary metric gets created? It seems obvious, but let me know what you think.

CC @gvnmagni

**Point visibility** {applies_to}`stack: ga 9.1` {applies_to}`serverless: ga`
: For **Area** and **Line** charts. Use this option to show or hide data points. Set to `Auto` by default: Points are visible unless the distance between them is too short.

#### Metrics

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not calling this section "Metric chart"? In other places in the same page they are called like this, such as "Show trends in Metric charts"

Copy link

@mariairiartef mariairiartef Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that it is also called metric visualization in "How does dynamic coloring work for the metric visualization?"

@mariairiartef
Copy link

@mariairiartef Do you think we should be more explicit about the fact that the Secondary metric alignment and the icon position are enabled only when a secondary metric gets created? It seems obvious, but let me know what you think.

CC @gvnmagni

I'd suggest we follow the approach used in the docs for consistency

@gvnmagni
Copy link

gvnmagni commented Oct 1, 2025

Here I am, thank you Arianna for the effort. I believe the only note I have is that where we describe the possibilities for primary metric we say:

Primary metric
Define the orientation of the primary metric in terms of Position, Alignment, and Font size.

The only concern I have is around the term Orientation, that I am not sure brings the right concept. I would have chosen a word like "placement" but I am not a native speaker and I might be have a misleading idea of the term Orientation in mind. Happy to keep it if it is instead more suited

@alaudazzi
Copy link
Contributor Author

@gvnmagni
Agreed, good point. On a second thought, as we are defining the Font size other than the Position and Alignment, we should probably rephrase with:

Primary metric
Define the formatting of the primary metric in terms of Position, Alignment, and Font size.

@gvnmagni
Copy link

gvnmagni commented Oct 1, 2025

That would work perfectly!

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alaudazzi alaudazzi merged commit 7ec393f into main Oct 3, 2025
7 checks passed
@alaudazzi alaudazzi deleted the fix-3088 branch October 3, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics charts] UI changes for Metrics charts

4 participants