-
Notifications
You must be signed in to change notification settings - Fork 155
Add appearance settings for metric chart #3246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
@mariairiartef CC @gvnmagni |
explore-analyze/visualize/lens.md
Outdated
**Point visibility** {applies_to}`stack: ga 9.1` {applies_to}`serverless: ga` | ||
: For **Area** and **Line** charts. Use this option to show or hide data points. Set to `Auto` by default: Points are visible unless the distance between them is too short. | ||
|
||
#### Metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not calling this section "Metric chart"? In other places in the same page they are called like this, such as "Show trends in Metric charts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that it is also called metric visualization in "How does dynamic coloring work for the metric visualization?"
I'd suggest we follow the approach used in the docs for consistency |
Here I am, thank you Arianna for the effort. I believe the only note I have is that where we describe the possibilities for primary metric we say:
The only concern I have is around the term Orientation, that I am not sure brings the right concept. I would have chosen a word like "placement" but I am not a native speaker and I might be have a misleading idea of the term Orientation in mind. Happy to keep it if it is instead more suited |
@gvnmagni
|
That would work perfectly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds the new appearance settings for the metric chart.
Closes #3088
Relates to elastic/kibana#229815 and elastic/kibana#233992