-
Notifications
You must be signed in to change notification settings - Fork 154
Add documentation for managing ECK file-based password length. #3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for managing ECK file-based password length. #3339
Conversation
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
🔍 Preview links for changed docs |
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have suggested to place the applies_to right after the heading, and not after the initial note.
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good. I think we want to consider relocating this chunk of info though because it's specific to the file realm. would you consider making it an H4 under the File realm
heading?
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(+ approving to unblock)
(oops, guess this tab was old and edu already got you)
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
@shainaraskas , @pebrc and I spoke, and though moving all of this under |
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - this grouping now makes more sense to me. added some additional comments that could clarify things a little further (and I think you have the wrong version # in there)
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - this grouping now makes more sense to me. added some additional comments that could clarify things a little further (and I think you have the wrong version # in there)
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
The following elastic/cloud-on-k8s#8817 is planned to be released with the ECK 3.2/Stack 9.2 release.
(replaces #3322 as it was based of the wrong branch)