-
Notifications
You must be signed in to change notification settings - Fork 156
Variable controls in Discover #3440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Variable controls in Discover #3440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for variable controls in Discover, enabling users to create dynamic queries with reusable controls that can be shared between Discover and Dashboards.
- Adds new section documenting how to create, edit, and use variable controls in Discover
- Creates shared content snippets for variable control configuration and examples to reduce duplication
- Documents the workflow for importing Discover queries with controls into dashboards
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
explore-analyze/discover/try-esql.md | Adds complete variable controls documentation for Discover including creation, editing, and dashboard import |
explore-analyze/dashboards/add-controls.md | Updates dashboard controls documentation to use shared snippets and adds import workflow |
explore-analyze/_snippets/variable-control-form.md | Creates shared snippet for variable control configuration parameters |
explore-analyze/_snippets/variable-control-examples.md | Creates shared snippet with ESQL query examples using variable controls |
explore-analyze/_snippets/import-discover-query-controls-into-dashboard.md | Creates shared snippet documenting the import workflow from Discover to Dashboard |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Added some small comments, nothing crucial
explore-analyze/_snippets/import-discover-query-controls-into-dashboard.md
Show resolved
Hide resolved
Co-authored-by: Stratou <stratoula1@gmail.com>
Co-authored-by: Stratou <stratoula1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some suggestions for your consideration! Hope they're helpful
explore-analyze/_snippets/import-discover-query-controls-into-dashboard.md
Outdated
Show resolved
Hide resolved
explore-analyze/_snippets/import-discover-query-controls-into-dashboard.md
Outdated
Show resolved
Hide resolved
…dashboard.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
…dashboard.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
This PR:
Find page previews in one of the comments below
Note: Tested on staging environment on Oct 10
Closes: #3096