Skip to content

Conversation

JohannesMahne
Copy link

Format changes to the bullet points for the benefits of serverless.

Format changes to the bullet points for the benefits of serverless.
@JohannesMahne JohannesMahne requested a review from a team as a code owner February 7, 2025 13:17
Copy link

github-actions bot commented Feb 7, 2025

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

@eedugon
Copy link
Contributor

eedugon commented Mar 11, 2025

@bmorelli25 : does it still make sense to apply changes in the serverless asciidoc documentation? This PR solves a small issue there.

Taking a look at the migrated documents it looks we have already fixed it in markdown :) https://docs-v3-preview.elastic.dev/elastic/docs-content/tree/main/deploy-manage/deploy/elastic-cloud/serverless

Should we cancel this PR or is it worthy to apply the fix in the current serverless docs too?

@bmorelli25 bmorelli25 changed the base branch from main to do-not-delete_legacy-docs March 11, 2025 23:20
@bmorelli25
Copy link
Member

Should we cancel this PR or is it worthy to apply the fix in the current serverless docs too?

We should apply this change, but not to the main branch. The serverless docs from now until 9.0 releases are being built from the do-not-delete_legacy-docs branch. I've changed the base branch of this PR to that branch. We can now merge this change and have the update go live today.

@bmorelli25 bmorelli25 merged commit c69bd94 into do-not-delete_legacy-docs Mar 11, 2025
3 checks passed
@bmorelli25 bmorelli25 deleted the JohannesMahne-patch-1 branch March 11, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants