Skip to content

[Docs] Add Sample data page #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

[Docs] Add Sample data page #493

merged 2 commits into from
Feb 19, 2025

Conversation

wajihaparvez
Copy link
Contributor

@wajihaparvez wajihaparvez commented Feb 18, 2025 •
edited
Loading

Closes #373
Preview here

Summary

What I changed:

  • Combined content from the two mapped pages and refined it to make sense in the new IA
  • Added new screenshots and nav instructions because the old ones were outdated
  • Deleted one of the linked raw migrated files. The other one is referenced in other pages

@wajihaparvez wajihaparvez self-assigned this Feb 18, 2025
kilfoyle
kilfoyle approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌵
Very nice!

@wajihaparvez wajihaparvez enabled auto-merge (squash) February 19, 2025 14:36
@wajihaparvez wajihaparvez merged commit 189efd7 into elastic:main Feb 19, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@colleenmcginnis colleenmcginnis Awaiting requested review from colleenmcginnis

Assignees

@wajihaparvez wajihaparvez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wajihaparvez @kilfoyle