Skip to content

Make ECS 1.7 the current release #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2020
Merged

Make ECS 1.7 the current release #2005

merged 2 commits into from
Nov 17, 2020

Conversation

webmat
Copy link

@webmat webmat commented Nov 16, 2020

Do not merge. Please let the ECS team merge this at the appropriate time.

@webmat webmat self-assigned this Nov 16, 2020
@webmat
Copy link
Author

webmat commented Nov 16, 2020 •
edited
Loading

Seems like this build failure is related to https://github.com/elastic/cloud/pull/70205

@webmat
Copy link
Author

webmat commented Nov 16, 2020

@elasticmachine, run elasticsearch-ci/docs

@webmat webmat added release Apply to issues tracking docs for releases and removed current labels Nov 16, 2020
gtback
gtback approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! I'll mark it as Draft so no one (especially me 😉 ) accidentally merges it, but feel free to merge when ready.

@gtback gtback marked this pull request as draft November 16, 2020 22:31
@webmat webmat marked this pull request as ready for review November 17, 2020 15:10
@webmat webmat merged commit 0ae72b6 into elastic:master Nov 17, 2020
@bmorelli25
Copy link
Member

What's the reasoning behind setting 1.7 as current, but only setting :ecs_version: 1.7 in master and not also 7.10? I don't think this creates a good experience for our users. Any links from stack current (7.10) to ECS documentation will be met with a yellow header:

"A newer version is available. For the latest information, see the current release documentation."

@webmat
Copy link
Author

webmat commented Nov 17, 2020

@bmorelli25 ECS 1.7 is to be adopted by Elastic Stack 7.11. That's why we release ECS 1 week after the previous stack release :-)

trentm added a commit to elastic/ecs-logging-nodejs that referenced this pull request Feb 3, 2021
@trentm
docs: avoid links to field anchors on ECS pages
bc21fca 
These aren't read until after 7.11 stack release.

Refs: elastic/docs#2005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtback gtback gtback approved these changes

Assignees

@webmat webmat

Labels
ecs release Apply to issues tracking docs for releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webmat @bmorelli25 @gtback