Skip to content

Adds new Java API book to Clients #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2021
Merged

Adds new Java API book to Clients #2230

merged 1 commit into from
Sep 30, 2021

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Sep 28, 2021 •
edited
Loading

Overview

This PR creates a new book under Elasticsearch Clients called Java API. It contains the elasticsearch-java and elasticsearch repositories as sources.

DO NOT merge before #2231

@szabosteve szabosteve requested a review from gtback September 28, 2021 10:01
@szabosteve szabosteve added the docs DO NOT USE for *contents* of our docs. Only use for documentation *about* this repo. label Sep 28, 2021
gtback
gtback approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I haven't seen this particular error before, but I can dig into it more if you need me to.

06:12:49 INFO:build_docs:asciidoctor: ERROR: partintro block can only be used when doctype is book and must be a child of a book part. Excluding block content.

@szabosteve
Copy link
Contributor Author

@elasticmachine test this please

@szabosteve szabosteve mentioned this pull request Sep 29, 2021
Closed
@gtback
Copy link
Member

gtback commented Sep 29, 2021

I think it might actually be the [partintro] in https://github.com/elastic/elasticsearch-java/blob/main/docs/index.asciidoc. Since this index.asciidoc file is now the top-level page for the book, you can't have a partintro block in that file. Maybe?

@szabosteve szabosteve mentioned this pull request Sep 30, 2021
Merged
@szabosteve
Copy link
Contributor Author

@elasticmachine test this please

@szabosteve szabosteve merged commit 9852b9c into elastic:master Sep 30, 2021
@szabosteve szabosteve deleted the java.api.book branch September 30, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtback gtback gtback approved these changes

Assignees
No one assigned
Labels
docs DO NOT USE for *contents* of our docs. Only use for documentation *about* this repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabosteve @gtback