Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7](backport #2406) Fix actions acks delay #2417

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 29, 2023

This is an automatic backport of pull request #2406 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix actions acks delay

* Make linter happy

* Add unit test replicating the issue and confirming that it works after the change

* Add changelog fragment

(cherry picked from commit c7abda1)
@mergify mergify bot requested a review from a team as a code owner March 29, 2023 16:53
@mergify mergify bot added the backport label Mar 29, 2023
@mergify mergify bot requested review from michalpristas and michel-laterman and removed request for a team March 29, 2023 16:53
@aleksmaus aleksmaus requested a review from cmacknz March 29, 2023 16:57
@aleksmaus
Copy link
Member

@cmacknz will coordinate this backport merging depending on timing of 8.7.0 release

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-29T16:53:26.785+0000

  • Duration: 18 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 4995
Skipped 23
Total 5018

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.387% (61/62) 👍
Files 68.72% (145/211) 👍
Classes 67.574% (273/404) 👍
Methods 52.774% (837/1586) 👍 0.03
Lines 37.89% (9203/24289) 👍 0.076
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member

cmacknz commented Mar 30, 2023

The tests here passed but the status was never reported https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2417/1/pipeline

Merging

@cmacknz cmacknz merged commit 3e226b4 into 8.7 Mar 30, 2023
@cmacknz cmacknz deleted the mergify/bp/8.7/pr-2406 branch March 30, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants