Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing memory limiter processor with extension #4689

Merged

Conversation

michalpristas
Copy link
Contributor

Replaces processor with extensions in order to avoid dropping events when processor hits the limits. Extension puts back-pressure on receivers

Fixes: #4665

@michalpristas michalpristas added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team backport-skip skip-changelog labels May 7, 2024
@michalpristas michalpristas self-assigned this May 7, 2024
@michalpristas michalpristas requested a review from a team as a code owner May 7, 2024 08:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

go.mod Outdated
Comment on lines 60 to 61
go.opentelemetry.io/collector/extension v0.97.0
go.opentelemetry.io/collector/extension/memorylimiterextension v0.97.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these into the OTel Collector dependencies require group?

Copy link
Contributor

mergify bot commented May 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b otel/memorylimiterextension upstream/otel/memorylimiterextension
git merge upstream/main
git push upstream otel/memorylimiterextension

Copy link
Contributor

mergify bot commented May 9, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b otel/memorylimiterextension upstream/otel/memorylimiterextension
git merge upstream/main
git push upstream otel/memorylimiterextension

@michalpristas michalpristas merged commit 13a4157 into elastic:main May 9, 2024
9 checks passed
@michalpristas michalpristas added backport-v8.14.0 Automated backport with mergify and removed backport-skip labels Jun 21, 2024
mergify bot pushed a commit that referenced this pull request Jun 21, 2024
(cherry picked from commit 13a4157)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTel mode] Replace memorylimitprocessor with memorylimitextension
3 participants