Update host.js => window.location is not defined #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window can be defined and yet window.location can be undefined: both "window" and "window.location" must be defined to access to "protocol" information
damienleroux
changed the title
|
@damienleroux thanks for the patch! Please consider signing the CLA so that we can review this pull |
|
It is done; I signed it. |
|
Hi, Could you confirm the CLA worked and complete the merge please? Regards |
|
LGTM |
spalger
added a commit
that referenced
this pull request
Jan 26, 2016
Update host.js => window.location is not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window can be defined and yet window.location can be undefined: both "window" and "window.location" must be defined to access to "protocol" information.
I encountered this problem where "window" was defined but not "window.location". This append when transpiling js file in a express-react-browserify env.
Regards