Semantic text notebook #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://gitnotebooks.com/elastic/elasticsearch-labs/pull/271 |
Mikep86
commented
Jun 17, 2024
Mikep86
commented
Jun 17, 2024
| "source": [ | ||
| "# Semantic Search with Semantic Text\n", | ||
| "\n", | ||
| "<a target=\"_blank\" href=\"https://colab.research.google.com/github/Mikep86/elasticsearch-labs/blob/semantic-text-notebook/notebooks/search/09-semantic-text.ipynb\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>\n", |
There was a problem hiding this comment.
Will fix this link before merging
Mikep86
commented
Jun 17, 2024
Mikep86
commented
Jun 17, 2024
Mikep86
commented
Jun 17, 2024
carlosdelest
approved these changes
Jun 18, 2024
|
@Mikep86 To prevent this notebook for running (and failing) in 8.14 and older CI runs, add a |
Mikep86
commented
Jul 1, 2024
Comment on lines
271
to
287
| "while True:\n", | ||
| " status = client.ml.get_trained_models_stats(\n", | ||
| " model_id=model_id,\n", | ||
| " )\n", | ||
| "\n", | ||
| " deployment_stats = status[\"trained_model_stats\"][0].get(\"deployment_stats\")\n", | ||
| " if deployment_stats is None:\n", | ||
| " print(\"ELSER Model is currently being deployed.\")\n", | ||
| " continue\n", | ||
| "\n", | ||
| " nodes = deployment_stats.get(\"nodes\")\n", | ||
| " if nodes is not None and len(nodes) > 0:\n", | ||
| " print(\"ELSER Model has been successfully deployed.\")\n", | ||
| " break\n", | ||
| " else:\n", | ||
| " print(\"ELSER Model is currently being deployed.\")\n", | ||
| " time.sleep(5)" |
There was a problem hiding this comment.
@joemcelroy I used the ELSER notebook as a guide for this code and modified it to work with inference endpoints. However, I found two issues when doing so:
- The notebook CI currently doesn't check against a serverless environment
- The status check used in the ELSER notebook breaks when run against a serverless environment.
trained_model_stats.0.deployment_stats.statedoesn't exist in the serverless response toclient.ml.get_trained_models_stats. Instead, I checked if thenodeslist is populated, which seems to work in both hosted & serverless environments.
|
@miguelgrinberg Seems like CI is broken on the |
joemcelroy
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a search notebook demonstrating basic, end-to-end usage of the
semantic_textfield type