Allow ConnectionFactory to be override #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, you're right, thanks for the PR. Merging! |
|
Thanks for the merge! |
|
I'm on the run at the moment and was going to cherry-pick the merge to 2.x when I got to my hotel tonight, but if you want to send a PR against 2.x branch that'd be even better! :) dev-master (soon to be 5.x) should theoretically mostly work with 2.x, but there are a few backwards incompatible things (mostly deprecated/removed APIs), so it'd be good to merge this change to 2.x directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the ConnectionFactory with the
ClientBuilder::setConnectionFactorycan't work since in AbstractConnectionPool class, it was not theConnectionFactoryInterfacethat is waiting but theConnectionFactoryAlso added 2 missing properties declaration.