Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gzip compression when setting Cloud Id #986

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fixed gzip compression when setting Cloud Id #986

merged 1 commit into from
Jan 14, 2020

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Jan 14, 2020

This PR fixes the gzip compression settings in CURL when Cloud Id is specified. The previous implementation had a wrong setting (here).
Moreover, this PR check if the CURLOPT_ENCODING is already set, in that case I don't change it when Cloud Id is specified.

@ezimuel ezimuel requested a review from philkra January 14, 2020 08:49
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezimuel ezimuel merged commit 0c1e0ca into elastic:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants