Skip to content

Surface caused_by in ApiError #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2025
Merged

Surface caused_by in ApiError #2932

merged 3 commits into from
Apr 18, 2025
+32 −0

Conversation

pquentin
Copy link
Member

In particular, this will give a clear error when using elasticsearch-py 9.0.0 on an 8.x clusters. Which helps with issues likes #2927 and #2923.

Before:

elasticsearch.BadRequestError: BadRequestError(400, 'media_type_header_exception', 'Invalid media-type value on headers [Accept, Content-Type]')

After:

elasticsearch.BadRequestError: BadRequestError(400, 'media_type_header_exception', 'Invalid media-type value on headers [Accept, Content-Type]', Accept version must be either version 8 or 7, but found 9. Accept=application/vnd.elasticsearch+json; compatible-with=9)

@pquentin
Surface caused_by in ApiError
28dd0ad 
In particular, this will give a clear error when using elasticsearch-py 9.0.0
on an 8.x clusters.
@pquentin pquentin requested a review from miguelgrinberg April 17, 2025 13:32
@pquentin pquentin enabled auto-merge (squash) April 18, 2025 06:51
@pquentin pquentin merged commit 72efd52 into elastic:main Apr 18, 2025
15 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
@pquentin @github-actions
Surface caused_by in ApiError (#2932)
052f66b 
In particular, this will give a clear error when using elasticsearch-py 9.0.0
on an 8.x cluster.

(cherry picked from commit 72efd52)
@github-actions github-actions bot mentioned this pull request Apr 18, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
@pquentin @github-actions
Surface caused_by in ApiError (#2932)
86b9036 
In particular, this will give a clear error when using elasticsearch-py 9.0.0
on an 8.x cluster.

(cherry picked from commit 72efd52)
@github-actions github-actions bot mentioned this pull request Apr 18, 2025
Merged
pquentin added a commit that referenced this pull request Apr 18, 2025
@github-actions @pquentin
Surface caused_by in ApiError (#2932) (#2934)
66baf16 
In particular, this will give a clear error when using elasticsearch-py 9.0.0
on an 8.x cluster.

(cherry picked from commit 72efd52)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Apr 18, 2025
@github-actions @pquentin
Surface caused_by in ApiError (#2932) (#2935)
826ec1b 
In particular, this will give a clear error when using elasticsearch-py 9.0.0
on an 8.x cluster.

(cherry picked from commit 72efd52)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
@miguelgrinberg miguelgrinberg mentioned this pull request May 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgrinberg miguelgrinberg miguelgrinberg approved these changes

Assignees
No one assigned
Labels
backport 8.19 backport 9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @miguelgrinberg