Support Trio with httpx #3089
Support Trio with httpx #3089
Conversation
🔍 Preview links for changed docs |
|
|
||
|
|
||
| async def _sleep(seconds: float) -> None: | ||
| if sniffio.current_async_library() == "trio": |
There was a problem hiding this comment.
Would it make sense to ask the transport what the current library is, since it stores it? Not super important, but it feels unnecessary to constantly run the detection logic in sniffio.
| dependencies = [ | ||
| "elastic-transport>=9.1.0,<10", | ||
| # TODO revert before merging/releasing | ||
| "elastic-transport @ git+https://github.com/pquentin/elastic-transport-python.git@trio-support", |
There was a problem hiding this comment.
Adding a comment here just to remind you that need this to be edited. (not sure if your TODO comment triggers some alert or linter...)
| if not hasattr(elasticsearch, "AsyncElasticsearch"): | ||
| pytest.skip("test requires 'AsyncElasticsearch' and aiohttp to be installed") | ||
|
|
||
| print("async!", elasticsearch_url) |
| from ...utils import parse_version | ||
|
|
||
| # We're not using `pytest.mark.anyio` here because it would run the test suite twice, | ||
| # which does not work as it does not fully clean up after itself. |
There was a problem hiding this comment.
Probably something that we'll want to address at some point.
| event_loop = asyncio.get_running_loop() | ||
| async def test_sniff_on_start_close_unlocks_async_calls(self, anyio_backend): | ||
| if anyio_backend == "trio": | ||
| pytest.skip("trio does not support sniffing") |
There was a problem hiding this comment.
I think it isn't necessary to skip here, or even use the anyio fixture and functions, since this whole class is marked with asyncio and not anyio.
| "sed", | ||
| "-i.bak", | ||
| "s/pytest.mark.asyncio/pytest.mark.sync/", | ||
| "s/pytest.mark.anyio/pytest.mark.sync/", |
There was a problem hiding this comment.
I think this should handle both anyio and asyncio markers, just in case. Unless we ignore the asyncio marker on purpose just so that the build fails when we mistakenly use it instead of anyio?
No description provided.