Skip to content

Conversation

jarda-manana
Copy link

Hi,
would you please consider pulling this change - it enables the usage of proxies in RequestsHttpConnection.
Thank you,
J. Balas

@coveralls
Copy link

Coverage Status

Coverage increased (+0.18%) when pulling aae95f5 on jarda-manana:master into 7da48e2 on elasticsearch:master.

@honzakral
Copy link
Contributor

If we do this we need to make sure it will also work for the preferred default connection class - urllib3 in a consistent way. Once we figure that out this can be merged.

@honzakral
Copy link
Contributor

This is too specific a change. If you need something like this I'd suggest you subclass the connection class and override the __init__ method to call the super and then set up anything you might want.

Also consider using the urllib3 connection class, we have had much better results with it.

Thanks!

@honzakral honzakral closed this Aug 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants