Thrift: Support for Default Headers and SSL #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale behind this is pretty much the same as in #1:
Many people use Elasticsearch over unsecured networks that requires encryption and authentication.
Added support for using a SSL-based Thrift socket. Since thrift has no support for authentication in it self, I added the ability to set some default headers on the
RestRequest
s, which is on par with HTTP-like interface of the Elasticsearch Thrift services. This enables, but leaves authentication as an implementation detail in the Thrift server-side, as it likely should be.I tried to put some consideration into the argument names, but I'm not 100% sure whether they should be prefixed with
thrift_
or not, so I left that in.