undefined method `page' - will_paginate

[mmahalwy]

Keep getting this error:

NoMethodError: undefined method 'page' for #<Elasticsearch::Model::Response::Response:0x007fe3107f2c90>

With will_paginate 3.0.6

My query:

Quran::Ayah.search("allah").page(2)

This works:

Quran::Ayah.page(2)

---

Also, for some reason ES is not exposing Elasticsearch::Model::Response::Results

2.1.2 :049 > ap Content::Translation.search("allah").results.current_page
NoMethodError: undefined method `current_page' for #<Elasticsearch::Model::Response::Response:0x007f915c656888>
2.1.2 :050 > ap Content::Translation.search("allah").current_page.results
NoMethodError: undefined method `current_page' for #<Elasticsearch::Model::Response::Response:0x007f915d7a39d8>

[mumoshu]

@mmahalwy Would you mind requiring will_paginate before elasticsearch-model, or just instructing Bundler to do that for you defining the dep to will_paginate before elasticsearch-model in Gemfile like:

gem "will_paginate"
gem "elasticsearch-model"

This is because those will_paginate methods are included automatically in elasticsearch/model.rb like:

case
when defined?(::Kaminari)
  Elasticsearch::Model::Response::Response.__send__ :include, Elasticsearch::Model::Response::Pagination::Kaminari
when defined?(::WillPaginate)
  Elasticsearch::Model::Response::Response.__send__ :include, Elasticsearch::Model::Response::Pagination::WillPaginate
end

which means that will_paginate gem which defines the constant WillPaginate must be loaded beforehand.

[mmahalwy]

I think that may be the problem. I ended up using kaminari and manually including it. But I think that may be the problem!

[karmi]

Yeah, @mumoshu is right, please consult the documentation, you have to include a pagination library. The examples has code which demonstrates how to trigger eg. Kaminari hooks manually, if you need to.

[mmahalwy]

Yes I understand. I just included the will_paginate gem after elasticsearch
and not before it. Good catch
ᐧ

On Thu, Sep 11, 2014 at 1:50 PM, Karel Minarik notifications@github.com
wrote:

Yeah, @mumoshu https://github.com/mumoshu is right, please consult the
documentation, you have to include a pagination library. The examples has
code which demonstrates how to trigger eg. Kaminari hooks manually, if you
need to.

—
Reply to this email directly or view it on GitHub
#239 (comment)
.

Mohamed El Mahallawy

@mmahalwy4167101981

[hlxwell]

@mmahalwy In my project, I found this issue also, but if in your gemfile

Include kaminari before elasticsearch libs will be ok.

gem 'kaminari'
gem 'elasticsearch-model', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'
gem 'elasticsearch-rails', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'

[coolprobn]

@mmahalwy In my project, I found this issue also, but if in your gemfile

Include kaminari before elasticsearch libs will be ok.

gem 'kaminari'
gem 'elasticsearch-model', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'
gem 'elasticsearch-rails', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'

This worked, does anyone know the reason behind this? 🤔

[sled]

@mmahalwy In my project, I found this issue also, but if in your gemfile
Include kaminari before elasticsearch libs will be ok.

gem 'kaminari'
gem 'elasticsearch-model', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'
gem 'elasticsearch-rails', git: 'git://github.com/elasticsearch/elasticsearch-rails.git'

This worked, does anyone know the reason behind this? 🤔

The reason is that Kaminari won't be defined if it's included after Elasticsearch:

https://github.com/elastic/elasticsearch-rails/blob/8fe0a555083d16d9d64dea7b0ae8a8695c1d4211/elasticsearch-model/lib/elasticsearch/model.rb#L58C1-L59