Kaminari Pagination with MultiModel Search

[rkrdo]

This is related to #382
Using the code from master, I'm trying to make a MultiModel Search:
(Elasticsearch::Model.search('search term', [User, Admin]).page(params[:page]).records)

And that works fine, however, when trying to use Kaminari's paginate helper with the records collection, I'm getting the following error:

NameError - undefined local variable or method `max_pages' for #<Elasticsearch::Model::Response::Records:0x007f99cd59b258>:
   () .../bundler/gems/elasticsearch-rails-ded203569208/elasticsearch-model/lib/elasticsearch/model/response/records.rb:58:in `method_missing'
  kaminari (0.16.3) lib/kaminari/models/page_scope_methods.rb:27:in `total_pages'
  kaminari (0.16.3) lib/kaminari/helpers/action_view_extension.rb:18:in `paginate'

I noticed that the Kaminari configuration methods are getting included in Elasticsearch::Model::Response::Results but not on Elasticsearch::Model::Response::Records (see model/response/pagination.rb), so including the Kaminari methods in Elasticsearch::Model::Response::Records fixes my issue.

Is there a reason why those methods don't get included in Elasticsearch::Model::Records ?

[jonfer]

I have same problem

[miguelff]

@rkrdo , @jonfer, is kaminari included in the Gemfile, before elasticsearch-*? (some context: #489, #487 (comment))

[jonfer]

@miguelff Yes

[jonfer]

Ok, this commit in Master fixes the problem: 5f32e48

[rkrdo]

@miguelff yeah, kaminari is included before elasticsearch-model and elasticsearch-rails in the Gemfile.

I'm using version 0.1.7 BTW, I noticed that 0.1.8 hasn't included the fix for this issue.
Also I'm still wondering why Elasticsearch::Model::Response::Records doesn't include Kaminari::ConfigurationMethods::ClassMethods (like in Elasticsearch::Model::Response::Results ), that would fix this specific issue.

[miguelff]

@rkrdo Yep, actually, Kaminari::ConfigurationMethods::ClassMethods is not needed in Response::Results either. For that reason, I removed it as part of #524

[rkrdo]

@miguelff Ah alright that sounds good, thanks for the reply!

Should I close this issue now or should I wait until the gem's version is bumped?

[karmi]

@rkrdo The patch has not been merged yet, I'll amend the commit during merge, so it should appear here, and close the issue.

[mindtonic]

Curious as to the status on this patch?

[miguelff]

cc @karmi ☝️

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.