[STORE] Make default doc type '_doc' in preparation for deprecation of mapping types #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e set, otherwise use _doc
…Repository object
estolfo
force-pushed
the
default_doc_type
branch
2 times, most recently
from
ce0b2fa
to
6b209f0
Compare
estolfo
added a commit
that referenced
this pull request
Jul 23, 2018
…f mapping types (#816) * [STORE] Require document_type or method options to set type in find requests * [STORE] Require document_type for a Repository to have a document type set, otherwise use _doc * [STORE] Use document_type or type in options for search requests * [STORE] Require #klass to be defined on a repository for deserialization * [STORE] Only rely on document_type setting in storage requests * [STORE] Fix up tests to work with default document_type and klass on Repository object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this documentation.
These changes will require users to define a
document_typeandklasson repository objects if they want to maintain previous behavior.The changes create a path for users to upgrade smoothly to ES 6 and to future versions of ES. Ultimately, document_type will be removed in 7.0, as there won't be the ability to define a mapping type.