Skip to content

[MODEL]respond_to_missing? to silence Ruby 2.4 warnings #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2018
Merged

[MODEL]respond_to_missing? to silence Ruby 2.4 warnings #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elasticsearch-model/lib/elasticsearch/model/response/result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def method_missing(name, *arguments)

# Respond to methods from `@result` or `@result._source`
#
def respond_to?(method_name, include_private = false)
def respond_to_missing?(method_name, include_private = false)
@result.respond_to?(method_name.to_sym) || \
@result._source && @result._source.respond_to?(method_name.to_sym) || \
super
Expand Down
8 changes: 8 additions & 0 deletions elasticsearch-model/spec/elasticsearch/model/response/result_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@
expect(result._source).to eq('bar' => { 'bam' => 'baz' })
end

it 'is recognized by #method' do
expect(result.method :bar).to be_a Method
end

it 'respond_to? still works' do
expect(result.respond_to? :bar).to be true
end

context 'when methods map to keys in subdocuments of the response from Elasticsearch' do

it 'provides access to top level fields via a method' do
Expand Down