Skip to content

Conversation

krojew
Copy link
Contributor

@krojew krojew commented Jan 15, 2021

closes #152

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jan 15, 2021

💚 CLA has been signed

@fteychene
Copy link

I tested the modification and it seems good 👍 .
The edits are equivalent as when I tried to update to tokio 0.3 before reqwest and hyper migrated.
As I'm not in the client team I can't start the Jenkins job 😅

@jeroenvanmaanen
Copy link

I would be delighted to see this on crates.io, because then I can update my project to Tokio 1.0 (archetype-rust-axon).

@Jasperav
Copy link

@russcam could you please have a look at this PR?

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @krojew 👍

@russcam russcam merged commit ecac915 into elastic:master Jan 27, 2021
@russcam russcam added enhancement New feature or request v7.10.1-alpha.1 labels Jan 27, 2021
russcam pushed a commit that referenced this pull request Jan 27, 2021
(cherry picked from commit ecac915)
russcam pushed a commit that referenced this pull request Jan 27, 2021
(cherry picked from commit ecac915)
@Jasperav
Copy link

@russcam thanks! When will this be available on crates?

@russcam
Copy link
Contributor

russcam commented Jan 27, 2021

@Jasperav It's up now 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v7.10.1-alpha.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Migration to tokio 1.0
6 participants