Connection url ends in trailing forward slash #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in relation to the usage of url::join(). If A url passed to Connection does not end in a trailing forward slash, a new url will be constructed from the passed url with a trailing forward slash. When joining a Connection url with an API path, the leading forward slash of the path is trimmed, so that the path is appended to the url rather than replacing any existing path segments. Fixes #48
russcam
commented
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in relation to the usage of url::join(). If A url
passed to Connection does not end in a trailing forward slash, a new url
will be constructed from the passed url with a trailing forward slash. When
joining a Connection url with an API path, the leading forward slash of the
path is trimmed, so that the path is appended to the url rather than replacing
any existing path segments.
Fixes #48