Skip to content

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 8, 2020

This commit allows elasticsearch to work with
rust stable. The only feature requiring rust nightly
is external_doc feature to able to to test the README.md
docs. This is now conditionally compiled
when building with rust nightly, using rustc_version
in a build.rs build script to set a cfg flag for the channel
used.

api_generator requires rust nightly still. The default toolchain
to use for each package is in a rust-toolchain file in
the root of each package directory.

Closes #87

This commit allows elasticsearch to work with
rust stable. The only feature requiring rust nightly
is external_doc feature to able to to test the README.md
docs. This is now conditionally compiled
when building with rust nightly, using rustc_version
in a build.rs build script to set a cfg flag for the channel
used.

api_generator requires rust nightly still. The default toolchain
to use for each package is in a rust-toolchain file in
the root of each package directory.

Closes #87
@russcam russcam added enhancement New feature or request v7.7.0-alpha.1 labels Apr 8, 2020
@russcam russcam merged commit a03fafb into master Apr 8, 2020
@russcam russcam deleted the enhancement/rust-stable branch April 8, 2020 22:23
russcam added a commit that referenced this pull request Apr 8, 2020
This commit allows elasticsearch to work with
rust stable. The only feature requiring rust nightly
is external_doc feature to able to to test the README.md
docs. This is now conditionally compiled
when building with rust nightly, using rustc_version
in a build.rs build script to set a cfg flag for the channel
used.

api_generator requires rust nightly still. The default toolchain
to use for each package is in a rust-toolchain file in
the root of each package directory.

Closes #87

(cherry picked from commit a03fafb)
russcam added a commit that referenced this pull request Apr 8, 2020
This commit allows elasticsearch to work with
rust stable. The only feature requiring rust nightly
is external_doc feature to able to to test the README.md
docs. This is now conditionally compiled
when building with rust nightly, using rustc_version
in a build.rs build script to set a cfg flag for the channel
used.

api_generator requires rust nightly still. The default toolchain
to use for each package is in a rust-toolchain file in
the root of each package directory.

Closes #87

(cherry picked from commit a03fafb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v7.7.0-alpha.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DISCUSS] Currently requires nightly release of rustc due to external_doc
1 participant