Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 23, 2024

Relates to #2635

This PR updates the tags and summaries for the get script language and context APIs (copied from https://www.elastic.co/guide/en/elasticsearch/reference/master/get-script-languages-api.html and https://www.elastic.co/guide/en/elasticsearch/reference/master/get-script-contexts-api.html).
It also adds the @doc_tag property so that the APIs are grouped with the other script APIs.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
get_script_context 🟢 1/1 1/1
get_script_languages 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a user October 23, 2024 01:44
@lcawl lcawl marked this pull request as ready for review October 23, 2024 01:44
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
get_script_context 🟢 1/1 1/1
get_script_languages 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 6cbaff5 into main Oct 23, 2024
6 checks passed
@lcawl lcawl deleted the lcawl/script-apis branch October 23, 2024 15:47
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants