Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 3, 2024

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_rules.delete_rule 🟢 6/6 6/6
query_rules.delete_ruleset 🟢 7/7 7/7
query_rules.get_rule 🟢 5/5 5/5
query_rules.get_ruleset 🟢 8/8 8/8
query_rules.list_rulesets 🟢 8/8 8/8
query_rules.put_rule 🟢 7/7 7/7
query_rules.put_ruleset 🟢 16/16 16/16
query_rules.test 🟢 9/9 9/9

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_rules.delete_rule 🟢 6/6 6/6
query_rules.delete_ruleset 🟢 7/7 7/7
query_rules.get_rule 🟢 5/5 5/5
query_rules.get_ruleset 🟢 8/8 8/8
query_rules.list_rulesets 🟢 8/8 8/8
query_rules.put_rule 🟢 7/7 7/7
query_rules.put_ruleset 🟢 16/16 16/16
query_rules.test 🟢 9/9 9/9

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐕

@lcawl lcawl merged commit 44a7732 into main Dec 4, 2024
7 checks passed
@lcawl lcawl deleted the query-rules-summary branch December 4, 2024 23:04
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
lcawl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 44a7732)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 44a7732)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 44a7732)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants