Skip to content

[DOCS] Add synonym operation summaries #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2024
Merged

[DOCS] Add synonym operation summaries #3220

merged 3 commits into from
Dec 5, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 4, 2024

@lcawl lcawl requested a review from a user December 4, 2024 00:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 27/27 27/27

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review December 4, 2024 00:09
@lcawl lcawl mentioned this pull request Dec 4, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 27/27 27/27

You can validate these APIs yourself by using the make validate target.

marciw
marciw approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ number style tweak

@lcawl @marciw
Update specification/synonyms/put_synonym/SynonymsPutRequest.ts
dfd370a 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 27/27 27/27

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 6fbd2ba into main Dec 5, 2024
7 checks passed
@lcawl lcawl deleted the synonyms-summary branch December 5, 2024 00:56
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@lcawl @marciw @github-actions
[DOCS] Add synonym operation summaries (#3220)
3189c24 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 6fbd2ba)
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@lcawl @marciw @github-actions
[DOCS] Add synonym operation summaries (#3220)
8e93319 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 6fbd2ba)
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@lcawl @marciw @github-actions
[DOCS] Add synonym operation summaries (#3220)
187a707 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 6fbd2ba)
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
lcawl added a commit that referenced this pull request Dec 5, 2024
@github-actions @lcawl
[DOCS] Add synonym operation summaries (#3220) (#3246)
154941c 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 6fbd2ba)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 5, 2024
@github-actions @lcawl
[DOCS] Add synonym operation summaries (#3220) (#3248)
eca88ad 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 6fbd2ba)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Dec 5, 2024
@github-actions @lcawl
[DOCS] Add synonym operation summaries (#3220) (#3247)
f94d8aa 
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
(cherry picked from commit 6fbd2ba)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marciw marciw marciw approved these changes

Assignees

No one assigned

Labels

backport 8.16 backport 8.17 backport 8.19 documentation OpenAPI specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lcawl @marciw