Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 30, 2024

This PR edits some summaries and descriptions in the ingest APIs based on information derived from https://www.elastic.co/guide/en/elasticsearch/reference/master/delete-ip-location-database-api.html, https://www.elastic.co/guide/en/elasticsearch/reference/master/get-ip-location-database-api.html, and https://www.elastic.co/guide/en/elasticsearch/reference/master/put-ip-location-database-api.html.

NOTE: https://www.elastic.co/guide/en/elasticsearch/reference/master/put-geoip-database-api.html exists only in the "deleted pages" section of the Elasticsearch Guide, so I'm assuming it will eventually be deprecated and removed from the specifications but that doesn't seem to have happened yet.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_ip_location_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_ip_location_database 🟢 7/7 7/7
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_ip_location_database 🟢 4/4 4/4
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

…ionDatabaseRequest.ts

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_ip_location_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_ip_location_database 🟢 7/7 7/7
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_ip_location_database 🟢 4/4 4/4
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 60ad301 into main Dec 31, 2024
7 checks passed
@lcawl lcawl deleted the ingest-apis branch December 31, 2024 19:32
github-actions bot pushed a commit that referenced this pull request Dec 31, 2024
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
(cherry picked from commit 60ad301)
github-actions bot pushed a commit that referenced this pull request Dec 31, 2024
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
(cherry picked from commit 60ad301)
lcawl added a commit that referenced this pull request Jan 7, 2025
* [DOCS] Edit ingest ip_location summaries (#3390)

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
(cherry picked from commit 60ad301)

* Regenerate output

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants