Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 2, 2025

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_data_lifecycle_stats Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review January 2, 2025 17:46
@lcawl lcawl requested a review from a team as a code owner January 2, 2025 17:46
@JoshMock JoshMock self-requested a review January 7, 2025 18:09
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, meant to hit "request changes" 🙃

lcawl and others added 2 commits January 7, 2025 14:41
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_data_lifecycle_stats Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_data_lifecycle_stats Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl
Copy link
Contributor Author

lcawl commented Jan 8, 2025

Thanks! I think I've addressed all the recommended changes.

lcawl and others added 4 commits January 8, 2025 10:23
…ifecycleStatsResponse.ts

Co-authored-by: Florian Bernd <git@flobernd.de>
…ifecycleStatsResponse.ts

Co-authored-by: Florian Bernd <git@flobernd.de>
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_data_lifecycle_stats Missing test Missing test

You can validate these APIs yourself by using the make validate target.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_data_lifecycle_stats Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_data_lifecycle_stats Missing test Missing test

You can validate these APIs yourself by using the make validate target.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.get_data_lifecycle_stats Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit bc0cb5b into main Jan 8, 2025
8 checks passed
@lcawl lcawl deleted the datastream-lifecycle branch January 8, 2025 20:08
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Co-authored-by: Josh Mock <joshua.mock@elastic.co>
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit bc0cb5b)
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Co-authored-by: Josh Mock <joshua.mock@elastic.co>
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit bc0cb5b)
lcawl added a commit that referenced this pull request Jan 8, 2025
Co-authored-by: Josh Mock <joshua.mock@elastic.co>
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit bc0cb5b)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Jan 8, 2025
Co-authored-by: Josh Mock <joshua.mock@elastic.co>
Co-authored-by: Florian Bernd <git@flobernd.de>
(cherry picked from commit bc0cb5b)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants