Skip to content

Use path alias in imports #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

Use path alias in imports #3935

merged 3 commits into from
Mar 12, 2025

Conversation

Anaethelion
Copy link
Contributor

Level the imports declaration with the rest of the spec.
Makes the type tree compatible with the current typescript-go state for testing purposes.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.update_filtering_validation 🟢 3/3 3/3
fleet.msearch ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.update_filtering_validation 🟢 3/3 3/3
fleet.msearch ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@Anaethelion Anaethelion requested a review from pquentin March 12, 2025 10:32
pquentin
pquentin approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tried to remove suppressImplicitAnyIndexErrors in the past as it's flagged by Zed but it was generating errors. Good riddance :)

@Anaethelion Anaethelion merged commit de5c2ef into main Mar 12, 2025
8 checks passed
@Anaethelion Anaethelion deleted the lsf/fix_ts_modules branch March 12, 2025 10:36
github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@Anaethelion @github-actions
Use path alias in imports (#3935)
0347828 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@Anaethelion @github-actions
Use path alias in imports (#3935)
c2d6969 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@Anaethelion @github-actions
Use path alias in imports (#3935)
6575c85 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@Anaethelion @github-actions
Use path alias in imports (#3935)
10497b4 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Merged
Anaethelion added a commit that referenced this pull request Mar 12, 2025
@github-actions @Anaethelion
Use path alias in imports (#3935) (#3936)
47af44a 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)

Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion added a commit that referenced this pull request Mar 12, 2025
@github-actions @Anaethelion
Use path alias in imports (#3935) (#3939)
37b6c8f 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)

Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion added a commit that referenced this pull request Mar 12, 2025
@github-actions @Anaethelion
Use path alias in imports (#3935) (#3938)
b82a02f 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)

Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion added a commit that referenced this pull request Mar 12, 2025
@github-actions @Anaethelion
Use path alias in imports (#3935) (#3937)
e898ca2 
* Use path alias

* Remove deprecated property

* Pleasing the linting gods

(cherry picked from commit de5c2ef)

Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pquentin pquentin pquentin approved these changes

Assignees

No one assigned

Labels

backport 8.17 backport 8.18 backport 8.19 backport 9.0 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Anaethelion @pquentin