Skip to content

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Mar 13, 2025

As defined in RestIndexAction.

Not backporting to 8.17 because of elastic/elasticsearch#120725.

This was noticed by @afharo in https://github.com/elastic/kibana/pull/213375/files#r1984114255.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
create 🟢 24/24 23/23

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server code for future references - LGTM!

@pquentin
Copy link
Member Author

Thanks for the review! I had linked the server code in the description

@pquentin pquentin merged commit bb844d6 into main Mar 13, 2025
14 checks passed
@pquentin pquentin deleted the create-missing-query-parameters branch March 13, 2025 16:13
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
pquentin added a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit bb844d6)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit bb844d6)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit bb844d6)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants