Skip to content

Conversation

pquentin
Copy link
Member

As suggested by @dakrone in #3926 (comment). The information was mostly in the pull request template, but that's arguably a bit too late.

@pquentin pquentin requested a review from a team as a code owner March 14, 2025 07:33
@dakrone
Copy link
Member

dakrone commented Mar 14, 2025

I know that the default target for make displays the help, but perhaps it could be changed to do all the necessary bits prior to a PR being submitted? A lot of folks are used to default make building as necessary (I know we have no make install equivalent for this).

No pressure, just a suggestion from my side!

@pquentin pquentin merged commit 509f88a into main Mar 28, 2025
8 checks passed
@pquentin pquentin deleted the contributing-guide branch March 28, 2025 18:35
@pquentin
Copy link
Member Author

Thank you for the suggestion. Changing make to make setup && make install could be interesting, but we probably need to make it fast to detect an existing install. For now, I have decided to merge what I had since it's a step in the right direction.

github-actions bot pushed a commit that referenced this pull request Mar 28, 2025
pquentin added a commit that referenced this pull request Mar 28, 2025
(cherry picked from commit 509f88a)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants