Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 25, 2025

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl requested a review from a team March 25, 2025 15:27
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.put_googlevertexai Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍞

@lcawl lcawl force-pushed the backport/8.18/pr-4028 branch from 69f31a0 to 2184afc Compare March 25, 2025 21:44
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.put_googlevertexai Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 0760e29 into 8.18 Mar 25, 2025
7 checks passed
@lcawl lcawl deleted the backport/8.18/pr-4028 branch March 25, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants