Skip to content

Conversation

lukewhiting
Copy link
Contributor

This pull request includes an update to the WatcherUpdateSettingsRequest documentation to clarify which settings can be modified for the Watcher internal index after elastic/elasticsearch#115251 was merged.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
watcher.update_settings Missing test Missing test

You can validate this API yourself by using the make validate target.

Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM.

@pquentin pquentin merged commit 8ac01e8 into main Mar 28, 2025
19 checks passed
@pquentin pquentin deleted the update-watcher-docs branch March 28, 2025 16:45
github-actions bot pushed a commit that referenced this pull request Mar 28, 2025
github-actions bot pushed a commit that referenced this pull request Mar 28, 2025
github-actions bot pushed a commit that referenced this pull request Mar 28, 2025
pquentin pushed a commit that referenced this pull request Mar 28, 2025
)

(cherry picked from commit 8ac01e8)

Co-authored-by: Luke Whiting <luke.whiting@elastic.co>
pquentin pushed a commit that referenced this pull request Mar 28, 2025
)

(cherry picked from commit 8ac01e8)

Co-authored-by: Luke Whiting <luke.whiting@elastic.co>
pquentin pushed a commit that referenced this pull request Mar 28, 2025
)

(cherry picked from commit 8ac01e8)

Co-authored-by: Luke Whiting <luke.whiting@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants