Skip to content

Fix type of max_concurrent_searches and max_concurrent_shard_requests #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Fix type of max_concurrent_searches and max_concurrent_shard_requests #4171

merged 1 commit into from
Mar 28, 2025

Conversation

pquentin
Copy link
Member

Since the long -> int changes in #4142 are breaking for Java and .NET for users that specify the L suffix or cast to long, I have extract them to this pull request that will only go in 9.x.

@pquentin pquentin requested review from flobernd and l-trotta March 28, 2025 12:20
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
async_search.submit 🟢 7/7 7/7
fleet.msearch ⚪ Missing test Missing test
fleet.search ⚪ Missing test Missing test
msearch 🟢 17/17 16/16
search 🔴 2320/2404 2387/2388

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin mentioned this pull request Mar 28, 2025
Merged
@pquentin pquentin merged commit 0cad693 into main Mar 28, 2025
9 of 10 checks passed
@pquentin pquentin deleted the max-long-int branch March 28, 2025 16:17
github-actions bot pushed a commit that referenced this pull request Mar 28, 2025
@pquentin @github-actions
Fix type of max_concurrent_searches and max_concurrent_shard_requests (…
5ddf272 
…#4171)

(cherry picked from commit 0cad693)
@github-actions github-actions bot mentioned this pull request Mar 28, 2025
Merged
pquentin added a commit that referenced this pull request Mar 28, 2025
@github-actions @pquentin
Fix type of max_concurrent_searches and max_concurrent_shard_requests (…
31c339b 
…#4171) (#4175)

(cherry picked from commit 0cad693)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l-trotta l-trotta l-trotta approved these changes

@flobernd flobernd Awaiting requested review from flobernd

Assignees

No one assigned

Labels

backport 9.0 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pquentin @l-trotta