Skip to content

Fixes names of legacy index template endpoints #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

Fixes names of legacy index template endpoints #4372

merged 3 commits into from
May 21, 2025

Conversation

szabosteve
Copy link
Contributor

Overview

Relates to elastic/docs-content#1402

This PR fixes the names of the legacy index template endpoints by adding legacy to the title to differentiate them.

@szabosteve szabosteve requested a review from stefnestor May 14, 2025 19:35
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.delete_template 🟢 9/9 9/9
indices.get_template 🟢 32/32 32/32
indices.put_template 🔴 45/46 46/46

You can validate these APIs yourself by using the make validate target.

stefnestor
stefnestor approved these changes May 14, 2025
View reviewed changes
Copy link

@stefnestor stefnestor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@l-trotta
Copy link
Contributor

@szabosteve if it's deprecated should we add the annotation?

@szabosteve
Copy link
Contributor Author

@l-trotta Oh, great catch! Thanks for spotting it! I amended it via 2b3f711.

@szabosteve szabosteve requested a review from l-trotta May 20, 2025 13:36
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.delete_template 🟢 9/9 9/9
indices.get_template 🟢 32/32 32/32
indices.put_template 🔴 45/46 46/46

You can validate these APIs yourself by using the make validate target.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.delete_template 🟢 9/9 9/9
indices.get_template 🟢 32/32 32/32
indices.put_template 🔴 45/46 46/46

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve merged commit 14f4ec9 into main May 21, 2025
8 checks passed
@szabosteve szabosteve deleted the szabosteve/issue-1402 branch May 21, 2025 13:25
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@szabosteve @github-actions
Fixes names of legacy index template endpoints (#4372)
82ab35a 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@szabosteve @github-actions
Fixes names of legacy index template endpoints (#4372)
cbd9247 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@szabosteve @github-actions
Fixes names of legacy index template endpoints (#4372)
6edc9ad 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@szabosteve @github-actions
Fixes names of legacy index template endpoints (#4372)
5986975 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
szabosteve added a commit that referenced this pull request May 21, 2025
@github-actions @szabosteve
Fixes names of legacy index template endpoints (#4372) (#4393)
f6fc1a2 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
szabosteve added a commit that referenced this pull request May 21, 2025
@github-actions @szabosteve
Fixes names of legacy index template endpoints (#4372) (#4394)
14d4577 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
szabosteve added a commit that referenced this pull request May 21, 2025
@github-actions @szabosteve
Fixes names of legacy index template endpoints (#4372) (#4395)
06f83b5 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
szabosteve added a commit that referenced this pull request May 21, 2025
@github-actions @szabosteve
Fixes names of legacy index template endpoints (#4372) (#4396)
355b4d7 
* Fixes names of legacy index template endpoints.

* Adds deprecation tag.

(cherry picked from commit 14f4ec9)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l-trotta l-trotta l-trotta approved these changes

+1 more reviewer

@stefnestor stefnestor stefnestor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 8.17 backport 8.18 backport 8.19 backport 9.0 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szabosteve @l-trotta @stefnestor