Fix self-referential type #5249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While allowed in TypeScript, this was not intended and causes stack overflows in generators.
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
l-trotta
approved these changes
Sep 2, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5249-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4699bd33070607edcf9c0a70e7d609e387cddc8d
# Push it to GitHub
git push --set-upstream origin backport-5249-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5249-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4699bd33070607edcf9c0a70e7d609e387cddc8d
# Push it to GitHub
git push --set-upstream origin backport-5249-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
pquentin
added a commit
that referenced
this pull request
Sep 2, 2025
* Fix self-referential type While allowed in TypeScript, this was not intended and causes stack overflows in generators. * Run make contrib (cherry picked from commit 4699bd3)
pquentin
added a commit
that referenced
this pull request
Sep 2, 2025
* Fix self-referential type While allowed in TypeScript, this was not intended and causes stack overflows in generators. * Run make contrib (cherry picked from commit 4699bd3)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
added a commit
that referenced
this pull request
Sep 2, 2025
pquentin
added a commit
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While allowed in TypeScript, this was not intended and causes stack overflows in generators.
Relates #5232