Skip to content

Conversation

alexey-ivanov-es
Copy link
Contributor

@alexey-ivanov-es alexey-ivanov-es commented Sep 15, 2025

Copy link
Contributor

github-actions bot commented Sep 15, 2025

Following you can find the validation changes against the target branch for the API.

API Status Request Response
search 🔴 2559/2637 → 2565/2637 2637/2637

You can validate this API yourself by using the make validate target.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still in draft but wanted to give it a first pass in case it's helpful!

prevalidate-node-removal,https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-cluster,https://www.elastic.co/guide/en/elasticsearch/reference/8.18/cluster.html,
preview-dfanalytics,https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-ml-preview-data-frame-analytics,https://www.elastic.co/guide/en/elasticsearch/reference/8.18/preview-dfanalytics.html,
preview-transform,https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-transform-preview-transform,https://www.elastic.co/guide/en/elasticsearch/reference/8.18/preview-transform.html,
project-tags,todo,,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some downstream docs generation tools may try to inject this todo as a URL in an HTML link, which could cause CI failures when docs jobs run their link-checker. Maybe try leaving it empty for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I left it empty for now

_id: string
_alias: string
_type: string
_organisation: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: linter is probably going to complain about using 4 spaces instead of 2. make sure to run code linting/formatting before committing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@alexey-ivanov-es
Copy link
Contributor Author

@JoshMock thank you!

@alexey-ivanov-es alexey-ivanov-es added the skip-backport This pull request should not be backported label Sep 24, 2025
@alexey-ivanov-es alexey-ivanov-es marked this pull request as ready for review September 24, 2025 15:14
@alexey-ivanov-es alexey-ivanov-es requested a review from a team as a code owner September 24, 2025 15:14
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoshMock
Copy link
Member

looks like the linter is not happy, so once that's fixed feel free to merge.

@alexey-ivanov-es alexey-ivanov-es changed the title [WIP] _project/tags endpoint _project/tags endpoint Sep 26, 2025
@alexey-ivanov-es alexey-ivanov-es merged commit 3ebca0e into main Sep 29, 2025
8 checks passed
@alexey-ivanov-es alexey-ivanov-es deleted the ES-12830 branch September 29, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serverless skip-backport This pull request should not be backported specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants