-
Notifications
You must be signed in to change notification settings - Fork 114
_project/tags endpoint #5293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_project/tags endpoint #5293
Conversation
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still in draft but wanted to give it a first pass in case it's helpful!
specification/_doc_ids/table.csv
Outdated
prevalidate-node-removal,https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-cluster,https://www.elastic.co/guide/en/elasticsearch/reference/8.18/cluster.html, | ||
preview-dfanalytics,https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-ml-preview-data-frame-analytics,https://www.elastic.co/guide/en/elasticsearch/reference/8.18/preview-dfanalytics.html, | ||
preview-transform,https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-transform-preview-transform,https://www.elastic.co/guide/en/elasticsearch/reference/8.18/preview-transform.html, | ||
project-tags,todo,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some downstream docs generation tools may try to inject this todo
as a URL in an HTML link, which could cause CI failures when docs jobs run their link-checker. Maybe try leaving it empty for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I left it empty for now
_id: string | ||
_alias: string | ||
_type: string | ||
_organisation: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: linter is probably going to complain about using 4 spaces instead of 2. make sure to run code linting/formatting before committing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
specification/project/tags/examples/response/FollowInfoResponseExample1.yaml
Outdated
Show resolved
Hide resolved
@JoshMock thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
looks like the linter is not happy, so once that's fixed feel free to merge. |
Main PR: https://github.com/elastic/elasticsearch-serverless/pull/4521