Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

Backport 4516b79 from #5341.

* Validate all APIs in PRs

The current code tries to guess which APIs could be affected by the PR, but it
does miss things. Now that full validation takes two minutes, we can always use
it.

* Fix lint

* Fix working directory before calling glob

* Fix detection of global APIs

(cherry picked from commit 4516b79)
@github-actions github-actions bot requested a review from a team as a code owner September 26, 2025 07:00
@pquentin pquentin closed this Sep 26, 2025
@pquentin pquentin reopened this Sep 26, 2025
Copy link
Contributor Author

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
bulk 🟢 553/553 → 543/543 571/571 → 561/561
cluster.allocation_explain 🟢 8/8 → 4/4 8/8 → 4/4
cluster.get_component_template 🟢 14/14 → 12/12 14/14 → 12/12
cluster.health 🟢 214/214 → 203/203 214/214 → 203/203
cluster.put_component_template 🔴 34/38 → 30/34 38/38 → 34/34
cluster.state 🟢 84/84 → 83/83 83/83 → 82/82
delete_by_query 🟢 8/8 → 7/7 7/7 → 6/6
esql.query 🔴 → 🟢 346/348 → 325/325 0/0
get 🟢 347/347 → 340/340 344/344 → 337/337
ilm.explain_lifecycle 🔴 → 🟢 5/5 4/5 → 5/5
index 🔴 → 🟢 1443/1443 → 1399/1399 1416/1445 → 1401/1401
indices.close 🟢 50/50 → 51/51 50/50 → 51/51
indices.create 🔴 1346/1386 → 1282/1324 1386/1386 → 1324/1324
indices.create_data_stream 🟢 121/121 → 116/116 121/121 → 116/116
indices.delete 🟢 119/119 → 114/114 119/119 → 114/114
indices.downsample 🟢 9/9 → 6/6 9/9 → 6/6
indices.flush 🟢 52/52 → 49/49 52/52 → 49/49
indices.forcemerge 🟢 14/14 → 13/13 14/14 → 13/13
indices.get_data_stream 🔴 124/124 → 115/115 77/124 → 71/115
indices.get_data_stream_settings 🟢 10/10 → 8/8 10/10 → 8/8
indices.get_field_mapping 🟢 30/30 → 18/18 30/30 → 18/18
indices.get_index_template 🟢 23/23 → 21/21 23/23 → 21/21
indices.get_mapping 🔴 228/228 → 203/203 215/228 → 193/203
indices.get_settings 🔴 85/85 → 84/84 66/85 → 65/84
indices.put_data_stream_settings 🔴 8/10 → 6/8 0/10 → 8/8
indices.put_index_template 🔴 130/154 → 124/147 154/154 → 147/147
indices.put_mapping 🔴 140/148 → 138/143 151/151 → 146/146
indices.refresh 🟢 316/316 → 302/302 316/316 → 302/302
indices.resolve_index 🟢 13/13 → 9/9 13/13 → 9/9
indices.rollover 🔴 56/56 → 52/52 2/56 → 2/52
indices.simulate_index_template 🔴 10/10 → 9/9 6/10 → 6/9
ingest.get_pipeline 🟢 23/23 → 22/22 23/23 → 22/22
ingest.put_pipeline 🟢 78/78 → 74/74 78/78 → 74/74
reindex 🔴 → 🟢 21/22 → 21/21 21/21 → 20/20
search 🔴 2403/2453 → 2337/2380 2453/2453 → 2380/2380
simulate.ingest 🟢 → 🔴 11/11 → 11/12 11/11 → 12/12
streams.logs_disable 🟢 3/3 → 1/1 3/3 → 1/1
streams.logs_enable 🟢 11/11 → 4/4 11/11 → 4/4
streams.status 🟢 10/10 → 5/5 10/10 → 5/5
update 🟢 49/49 → 46/46 49/49 → 46/46

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 4270848 into 9.1 Sep 26, 2025
8 checks passed
@pquentin pquentin deleted the backport-5341-to-9.1 branch September 26, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant