Rely on npm more in make validate #5352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
JoshMock
approved these changes
Sep 26, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2025
(cherry picked from commit eca32a3)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2025
(cherry picked from commit eca32a3)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2025
(cherry picked from commit eca32a3)
pquentin
added a commit
that referenced
this pull request
Sep 27, 2025
pquentin
added a commit
that referenced
this pull request
Sep 27, 2025
pquentin
added a commit
that referenced
this pull request
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble running
make validateon 8.19, and it turns out it was a weird interaction with an outdatedlibcontent. Using the npm commands referenced bymake contribis simpler and more robust.