Skip to content

Conversation

gmjehovich
Copy link
Contributor

Add certificate_identity field to API key specs

Updates TypeScript specs for create/update cross-cluster API key endpoints and ApiKey response type to include certificate_identity field.

@gmjehovich gmjehovich requested a review from jfreden October 6, 2025 16:30
@gmjehovich gmjehovich self-assigned this Oct 6, 2025
@gmjehovich
Copy link
Contributor Author

Wondering if I need to make a new separate CertificateIdentity type, or if keeping it as string like I have now is fine.

Also, I didn't add anything to the query spec- Are we going to support querying by cert_identity?

Finally, I didn't include the Serverless availability tag, is this correct?

@gmjehovich gmjehovich added the skip-backport This pull request should not be backported label Oct 6, 2025
@pquentin
Copy link
Member

pquentin commented Oct 7, 2025

Thank you for this! Can you please open this from a branch to ensure CI runs? As mentioned in CONTRIBUTING.md.

Wondering if I need to make a new separate CertificateIdentity type, or if keeping it as string like I have now is fine.

If it's an enum, it would make sense to add a type. Can you please link to the corresponding Elasticsearch PR so that I can look?

Also, I didn't add anything to the query spec- Are we going to support querying by cert_identity?

What is the "query spec"?

Finally, I didn't include the Serverless availability tag, is this correct?

If it's not meant for serverless than yes it is correct!

@jfreden
Copy link
Contributor

jfreden commented Oct 7, 2025

Wondering if I need to make a new separate CertificateIdentity type, or if keeping it as string like I have now is fine.

Since this can be any string (a regex) I think keeping it as String makes sense.

@pquentin this is the PR: elastic/elasticsearch#134604

Also, I didn't add anything to the query spec- Are we going to support querying by cert_identity?

No, we should not support that yet so makes sense to leave that out.

Finally, I didn't include the Serverless availability tag, is this correct?

Yes, that's correct. We currently do not support this in serverless

@gmjehovich
Copy link
Contributor Author

Closing. Opened new PR from a branch instead of a fork: #5446

@gmjehovich gmjehovich closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants