Skip to content

[Backport 8.19] Fix change point #5441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

[Backport 8.19] Fix change point #5441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions specification/_types/aggregations/Aggregate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ export class MultiBucketBase
}

/** @variant name=change_point */
export class ChangePointAggregate extends MultiBucketAggregateBase<ChangePointBucket> {
export class ChangePointAggregate extends AggregateBase {
type: ChangeType
bucket?: ChangePointBucket
}
Expand All @@ -396,51 +396,44 @@ export class ChangePointBucket extends MultiBucketBase {
}

/**
* @variants typed_keys_quirk
* @variants container
*/
export type ChangeType =
| Dip
| DistributionChange
| Indeterminable
| NonStationary
| Spike
| Stationary
| StepChange
| TrendChange
export class ChangeType {
dip?: Dip
distribution_change?: DistributionChange
indeterminable?: Indeterminable
non_stationary?: NonStationary
spike?: Spike
stationary?: Stationary
step_change?: StepChange
trend_change?: TrendChange
}

export class AbstractChangePoint {
p_value: double
change_point: integer
}

/** @variant name=dip */
export class Dip extends AbstractChangePoint {}

/** @variant name=distribution_change */
export class DistributionChange extends AbstractChangePoint {}

/** @variant name=spike */
export class Spike extends AbstractChangePoint {}

/** @variant name=step_change */
export class StepChange extends AbstractChangePoint {}

/** @variant name=indeterminable */
export class Indeterminable {
reason: string
}

/** @variant name=non_stationary */
export class NonStationary {
p_value: double
r_value: double
trend: string
}

/** @variant name=stationary */
export class Stationary {}

/** @variant name=trend_change */
export class TrendChange {
p_value: double
r_value: double
Expand Down