Skip to content

Conversation

bpintea
Copy link
Collaborator

@bpintea bpintea commented Dec 12, 2019

This PR adds the option to compress the HTTP/REST payload
(CBOR/JSON):

  • zlib is added as a build dependency, libcurl is now compiled against
    zlib and zlib is statically linked into the driver DLL;
  • a new connection string "Compress" controls the addition of the
    Accept-Encoding HTTP header, with possible values "on", "off" and "auto"
    (which adds the header if encryption is not enabled);
  • the possibility to build and ship libcurl as a dynamic library along
    the driver has been removed.

Additionally, this PR switches the default payload format to CBOR.

This commit adds the option to compress the HTTP/REST payload
(CBOR/JSON):
- zlib is added as a build dependency, libcurl is now compiled against
zlib and zlib is statically linked into the driver DLL;
- a new connection string "Compress" controls the addition of the
Accept-Encoding HTTP header, with possible values "on", "off" and "auto"
(which adds the header if encryption is not enabled);
- the possibility to build and ship libcurl as a dynamic library along
the driver has been removed.

Additionally, this commit switches the default payload format to CBOR.
add zlib license files
@bpintea bpintea added >feature Applicable to PRs adding new functionality v8.0.0-alpha1 v7.6.0 labels Dec 12, 2019
@bpintea bpintea changed the title Feat/add payload compression Enable payload compression Dec 12, 2019
Update comment about installing zlib files.
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Correct code comment (copy&paste error).
@bpintea bpintea merged commit eb04bae into elastic:master Dec 13, 2019
@bpintea bpintea deleted the feat/add_payload_compression branch December 13, 2019 11:47
bpintea added a commit that referenced this pull request Dec 16, 2019
* enable HTTP payload compression with zlib

This commit adds the option to compress the HTTP/REST payload
(CBOR/JSON):
- zlib is added as a build dependency, libcurl is now compiled against
zlib and zlib is statically linked into the driver DLL;
- a new connection string "Compress" controls the addition of the
Accept-Encoding HTTP header, with possible values "on", "off" and "auto"
(which adds the header if encryption is not enabled);
- the possibility to build and ship libcurl as a dynamic library along
the driver has been removed.

Additionally, this commit switches the default payload format to CBOR.

* add zlib license files

add zlib license files

* fix outdated comment

Update comment about installing zlib files.

* fix another c&p wrong comment

Correct code comment (copy&paste error).

(cherry picked from commit eb04bae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature Applicable to PRs adding new functionality v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants