Fix varchar type definition #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the mappings of the varchar types to the ODBC data types: - the KEYWORD, CONSTANT_KEYWORD and TEXT types are now SQL_WVARCHAR, which allows certain applications to correctly read the UTF8 content. - IP and the other string types (like GEO ones) remain to the previous SQL_VARCHAR types. The handling of double types has also been fixed to reflect the correction in Elasticsearch/SQL that now maps DOUBLE and SCALED_FLOAT to the same type (SQL_DOUBLE).
add tests querying for SQL source type.
update the definition of the ES/SQL types used in unit tests.
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
* Fix ES varchar types mappings to ODBC types This commit fixes the mappings of the varchar types to the ODBC data types: - the KEYWORD, CONSTANT_KEYWORD and TEXT types are now SQL_WVARCHAR, which allows certain applications to correctly read the UTF8 content. - IP and the other string types (like GEO ones) remain to the previous SQL_VARCHAR types. The handling of double types has also been fixed to reflect the correction in Elasticsearch/SQL that now maps DOUBLE and SCALED_FLOAT to the same type (SQL_DOUBLE). * Supplement tests for the varchar type change add tests querying for SQL source type. * update types defs for unit test update the definition of the ES/SQL types used in unit tests. (cherry picked from commit 45a82b1)
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
* Fix ES varchar types mappings to ODBC types This commit fixes the mappings of the varchar types to the ODBC data types: - the KEYWORD, CONSTANT_KEYWORD and TEXT types are now SQL_WVARCHAR, which allows certain applications to correctly read the UTF8 content. - IP and the other string types (like GEO ones) remain to the previous SQL_VARCHAR types. The handling of double types has also been fixed to reflect the correction in Elasticsearch/SQL that now maps DOUBLE and SCALED_FLOAT to the same type (SQL_DOUBLE). * Supplement tests for the varchar type change add tests querying for SQL source type. * update types defs for unit test update the definition of the ES/SQL types used in unit tests. (cherry picked from commit 45a82b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the mappings of ES/SQL's varchar types to the ODBC SQL data
types:
Most applications will request the driver translation to a wide string, but
some inspect and differentiate between SQL_WVARCHAR and SQL_VARCHAR source
types and will request translation to a SQL_C_WCHAR and SQL_C_CHAR type
respectively. In case the target C type is SQL_C_WCHAR, the driver needs to do
a recoding to UTF16.
SQL_VARCHAR types.
The handling of double types has also been fixed to reflect the
correction in Elasticsearch/SQL that now maps DOUBLE and SCALED_FLOAT to
the same type (SQL_DOUBLE).