-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] IndicesRequestCacheIT.testQueryRewriteDates failure #61565
Comments
Pinging @elastic/es-search (:Search/Search) |
I have checked the fix #54071 and it does not apply to 6.8, as it modifies serialization so that newly added fields are not considered part of the cache key. Those newly added fields are not present in 6.8, so it must be a different problem. |
Another failure: https://gradle-enterprise.elastic.co/s/diklknl2excoi
|
2 more failures in the last 60 days on 6.8. The last failure on July 5th: FAILURE 1.56s J15 \| IndicesRequestCacheIT.testQueryRewriteDatesWithNow <<< FAILURES! |
-- | --
| > Throwable #1: java.lang.AssertionError: expected:<[1, 1]> but was:<[0, 2]> |
| > at __randomizedtesting.SeedInfo.seed([A038FE2ED1BE81BA:143AF78E66EB6D55]:0) |
| > at org.elasticsearch.indices.IndicesRequestCacheIT.assertCacheState(IndicesRequestCacheIT.java:418) |
| > at org.elasticsearch.indices.IndicesRequestCacheIT.testQueryRewriteDatesWithNow(IndicesRequestCacheIT.java:286) |
This test fails from time to time on 6.8 This patch tries to address failures in 2 ways: 1. Disables automatic refreshes. Request cache gets invalidated when refresh happens (as IndexReader's version may change), which may lead to test failures. 2. Makes predictable indexing. Before we were using random indexing requests that could lead to multiple segments with deleted documents. This patch ensures that we are indexing only necessary docs in a single bulk request which should create only a single segment for each index. Relates to #61565
I think we should close this one as NOFIX. ES 6.8 will be EOL in a couple of weeks. |
Build scan:
https://gradle-enterprise.elastic.co/s/g2zdlxmibxf54
Repro line:
Reproduces locally?:
No
Applicable branches:
It seems to be
6.8
only.Failure history:
Only failed 3 times for
6.8
in past 60 days based on build-stats. But the error message looks pretty valid.We had an issue (#32827) that is similar to this. It has been fixed by #54071. But the fix is for 7.7+. I wonder whether it is related and needs to be backported to
6.8
.Failure excerpt:
The text was updated successfully, but these errors were encountered: