Stabilize IndicesRequestCacheIT test #75315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails from time to time on 6.8 This patch tries to address failures in 2 ways: 1. Disables automatic refreshes. Request cache gets invalidated when refresh happens (as IndexReader's version may change), which may lead to test failurs. 2. Makes predictable indexing. Before we were using random indexing requests that could lead to multiple segments with deleted documents. This patch ensures that we are indexing only necessary docs in a single bulk request which should create only a single segment for each index. Relates to elastic#61565
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
mayya-sharipova
added
>test-failure
dnhatn
approved these changes
Jul 15, 2021
server/src/test/java/org/elasticsearch/indices/IndicesRequestCacheIT.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/indices/IndicesRequestCacheIT.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails from time to time on 6.8
This patch tries to address failures in 2 ways:
invalidated when refresh happens (as IndexReader's version
may change), which may lead to test failurs.
random indexing requests that could lead to multiple
segments with deleted documents. This patch ensures
that we are indexing only necessary docs in a single
bulk request which should create only a single segment
for each index.
Relates to #61565